stubgen: handle PEP 604 unions in inspection mode (#21689)#21699
Open
apoorvdarshan wants to merge 1 commit into
Open
stubgen: handle PEP 604 unions in inspection mode (#21689)#21699apoorvdarshan wants to merge 1 commit into
apoorvdarshan wants to merge 1 commit into
Conversation
InspectionStubGenerator.get_type_fullname() did getattr(typ, '__qualname__', typ.__name__), which raised AttributeError for a types.UnionType (PEP 604 'X | Y'), crashing 'stubgen --inspect-mode' on any function whose signature uses the new union syntax. Render a UnionType by joining its members, mapping NoneType to None. Fixes python#21689.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #21689.
stubgen --inspect-modecrashes withAttributeErroron any function whose signature uses PEP 604 union syntax (X | Y):Root cause:
InspectionStubGenerator.get_type_fullname()assumes the object is a class and reads__qualname__/__name__, but a runtimetypes.UnionType(the value ofint | str) has neither.Fix: render a
UnionTypeby recursively formatting its members and joining with|, mappingNoneTypetoNoneso e.g.float | Nonerenders correctly.Added a
_inspecttest intest-data/unit/stubgen.test(fails onmaster, passes here).stubgensuite green (the one unrelatedtestAttrsClass_semanalfailure is pre-existing in my environment),mypyself-check andruffclean.Disclosure: prepared with AI assistance; reviewed and verified locally.